Prometheus fix inf bucket count #15287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
approved these changes
Oct 19, 2022
This change fixed it: prometheus/client_golang#1148 Or is there something I missed? |
|
I just noticed a change in pkg/translator/prometheusremotewrite/helper.go, but not in the prometheus exporter. Is the dependency bump all that is required for that exporter? |
dashpole
added
exporter/prometheus
bug
Yes, as far as I can tell, that is all that is required. |
codeboten
approved these changes
Oct 20, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
+Inf bucket counts are handled incorrectly in both prometheusexporter and prometheusremotewriteexporter.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
+Infbucket counts are handled incorrectly in bothprometheusexporterandprometheusremotewriteexporter.In prometheus this bug was taken care of by the following PR: prometheus/client_golang#1148
For
prometheusremotewriteexporterwe need to make the same fix and assign value of the total count to the+Infbucket as well.This issue caused New Relic to drop our histogram datapoints that had invalid values. It was a problem with 0.61.0 as well, but became much worse with 0.62.0. We built a custom image updating
github.com/prometheus/client_golangto the SHA version (dcea97eee2b3257f34fd3203cb922eedeabb42a6) that contained our fix and the issue disappeared:Link to tracking Issue: #4975