[receiver/elasticsearch]: fix the list of operations for which metrics are fetched on index level #16513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
Dec 5, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…s are fetched on index level (open-telemetry#16513) fix: fix the list of operations for which metrics are fetched on index level
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When I introduced scraping the metrics on index level in #14748, I set the query parameters so that the receiver fetched only metrics related to
searchoperations (which are query, fetch, scroll and suggest). I forgot to update that list as I added new metrics and datapoints. Because of that, most of metrics emitted by this receiver were sent with Golang's zero values (as this is a result of how JSONs are deserialised when a given field does not exist).Please also note that the integration tests did not cover it, because they ignore the exact values of metrics.
Link to tracking Issue: #14635
Testing:
Manual (checking the values before and after the fix)