[receiver/snmp] Add column and scalar OID metrics to resources that have scalar OID attributes #25174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
requested review from
djaglowski,
StefanKurek and
tamir-michaeli
djaglowski
reviewed
Aug 16, 2023
djaglowski
reviewed
Aug 16, 2023
StefanKurek
reviewed
Aug 16, 2023
StefanKurek
approved these changes
Aug 17, 2023
…alar resource attributes in config validation
kuiperda
force-pushed
the
feat/snmpreceiver-resource-attribute-updates
branch
from
802cd8e to
b177fa9
Compare
StefanKurek
reviewed
Aug 21, 2023
…tor-contrib into feat/snmpreceiver-resource-attribute-updates
djaglowski
reviewed
Aug 22, 2023
StefanKurek
reviewed
Aug 22, 2023
StefanKurek
reviewed
Aug 22, 2023
StefanKurek
approved these changes
Aug 22, 2023
|
Please address CI failures. Feel free to ping me to run actions after you push. |
…tor-contrib into feat/snmpreceiver-resource-attribute-updates
…tor-contrib into feat/snmpreceiver-resource-attribute-updates
…tor-contrib into feat/snmpreceiver-resource-attribute-updates
…tor-contrib into feat/snmpreceiver-resource-attribute-updates
…tor-contrib into feat/snmpreceiver-resource-attribute-updates
djaglowski
changed the title
djaglowski
approved these changes
Aug 29, 2023
This was referenced Aug 29, 2023
Closed
djaglowski
pushed a commit
that referenced
this pull request
Sep 5, 2023
**Description:** Fixed a bug introduced by [#25174](#25174) There was check that was supposed to ensure that all resource attributes added to a metric were scalar, but it was really checking if the number of resource attributes on a metric was the same as the total number of possible scalar resource attributes defined in the config. This check has been updated to explicitly verify that all of the resource attributes on the metric are scalar. Bug examples: - A column metric indexed by a column attribute has two scalar resource attributes with different names but the same oid value. They are the only two scalar RAs defined in the config. Since the oids are added to a map whose length is checked, they are seen as one value and the comparison fails so many resources are created instead of one. - A column metric indexed by a column attribute has only one scalar resource attribute when two possible attributes are defined in the config. The check fails and many resources are created instead of one. **Testing:** - Test that a metric with one scalar resource attribute when two are available still creates only one resource - First bug does not feel necessary to unit test, it has been tested locally and is fixed. **Documentation:** - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
#23373
Testing:
Documentation: