Replace jpkrohling with yurishkuro for Jaeger components #29658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatsheep9146
approved these changes
Dec 5, 2023
yurishkuro
approved these changes
Dec 5, 2023
.github/CODEOWNERS
Outdated
| extension/jaegerremotesampling/ @open-telemetry/collector-contrib-approvers @jpkrohling @frzifus | ||
| extension/jaegerremotesampling/internal/jaegerremotesamplingdeprecated/ @open-telemetry/collector-contrib-approvers @jpkrohling @frzifus | ||
| extension/jaegerremotesampling/ @open-telemetry/collector-contrib-approvers @yurishkuro @frzifus | ||
| extension/jaegerremotesampling/internal/jaegerremotesamplingdeprecated/ @open-telemetry/collector-contrib-approvers @yurishkuro @frzifus |
.github/CODEOWNERS
Outdated
| receiver/jaegerreceiver/ @open-telemetry/collector-contrib-approvers @jpkrohling | ||
| receiver/jaegerreceiver/internal/jaegerreceiverdeprecated/ @open-telemetry/collector-contrib-approvers @jpkrohling | ||
| receiver/jaegerreceiver/ @open-telemetry/collector-contrib-approvers @yurishkuro | ||
| receiver/jaegerreceiver/internal/jaegerreceiverdeprecated/ @open-telemetry/collector-contrib-approvers @yurishkuro |
| @@ -10,4 +10,4 @@ status: | |||
| - redhat | |||
| - sumo | |||
| codeowners: | |||
| active: [jpkrohling, frzifus] | |||
| active: [yurishkuro, frzifus] | |||
There was a problem hiding this comment.
why is internal package tracked separately? it's not a module.
codeboten
reviewed
Dec 5, 2023
There was a problem hiding this comment.
@yurishkuro the deprecated modules will be removed in this PR: #27636
songy23
reviewed
Dec 5, 2023
frzifus
approved these changes
Dec 6, 2023
jpkrohling
force-pushed
the
jpkrohling/replace-jaeger-codeowners
branch
from
d99223e to
7170744
Compare
codeboten
approved these changes
Dec 6, 2023
|
crobert-1
approved these changes
Dec 6, 2023
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
jpkrohling/replace-jaeger-codeowners
branch
from
7170744 to
ee35868
Compare
I've been doing the changes manually, given that this doesn't work for me: It might take a couple of more iterations to get this done, sorry about that. |
|
I decided to sort out that specific sum mismatch and was able to run |
songy23
approved these changes
Dec 8, 2023
songy23
added
the
ready to merge
TylerHelmuth
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to resign from a few components, as I'm not doing a good job in keeping track of what needs to be done for them. Asking around, @yurishkuro volunteered to take over the Jaeger related ones.
Signed-off-by: Juraci Paixão Kröhling [email protected]