[chore] Refactor/move LogEmitter to make it reusable by operators #32629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg/stanza
processor/logstransform
ChrsMark
force-pushed
the
move_logemitter_to_common_lib
branch
3 times, most recently
from
a6fa5ec to
787d5c4
Compare
ChrsMark
changed the title
ChrsMark
force-pushed
the
move_logemitter_to_common_lib
branch
2 times, most recently
from
0cd74e1 to
96b465a
Compare
ChrsMark
force-pushed
the
move_logemitter_to_common_lib
branch
from
d4eab2b to
b46163a
Compare
ChrsMark
commented
Apr 23, 2024
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
move_logemitter_to_common_lib
branch
from
b46163a to
5361e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR moves
LogEmitterto a common place inpkg/stanza/operator/helperso as to be reusable by operators without hitting circular imports.This is explained at #31959 (comment).
Link to tracking Issue:
Testing:
Documentation: