[receiver/vcenter] Replaces Deprecated Packet Metrics #33167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
feat/vcenterreceiver-update-dep-metrics
branch
from
6d5eebd to
275a430
Compare
djaglowski
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This mostly replaced deprecated packet metrics which already had a warning. Namely
vcenter.host.network.packet.errors,vcenter.host.network.packet.count, andvcenter.vm.network.packet.count. They are replaced through enabling by default (while removing the existing warnings) the metricsvcenter.host.network.packet.error.rate,vcenter.host.network.packet.rate, andvcenter.vm.network.packet.raterespectively.The metric
vcenter.vm.network.packet.rateis also enabled by default (while removing its current warning).Link to tracking Issue:
#32929 #32835
Testing:
Unit tests updated/ran. Integration tests ran. Local environment checked.
Documentation:
Documentation regenerated from metadata.