[pkg/stanza] Windows input operator logs noisy error while collecting successfully #35520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Oct 1, 2024
kuiperda
force-pushed
the
fix/remote-windows-noisy-error
branch
from
2e5bfc7 to
7a2d1c1
Compare
2 tasks
pjanotti
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Not from this change, but, this seems to leak the remote session handle, since closing the subscription doesn't closes it. That said I think this happened because the way the code is structured: this would have been avoided if the remote session handle was also part of the subscription.
kuiperda
force-pushed
the
fix/remote-windows-noisy-error
branch
from
7a2d1c1 to
d62ab10
Compare
|
@pjanotti Thanks for your feedback. I updated the return for that function. |
|
@pjanotti I'll make the issue but likely will not have time to work on it. |
djaglowski
approved these changes
Oct 3, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
… successfully (open-telemetry#35520) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> If `Input::read` returns 0, the operator will attempt to open the subscription again. This happens after a resubscribe *or* whenever there are no event logs to read, which is often. As a result, this error gets logged constantly: ``` "Failed to re-open subscription for remote server"..."error: subscription handle is already open" ``` To fix this, the handle should only attempt to re-open when the resubscribe happens. This is a followup to open-telemetry#35175 which fixed that resubscribe issue for the user that raised it, but they have also been confused by this error being logged. **Link to tracking Issue:** <Issue number if applicable> **N/A** **Testing:** <Describe what testing was performed and which tests were added.> Manually verified log collection is successful before and after remote host reconnects, and that the noisy error is silenced except during resubscribe, where it is relevant. **Documentation:** <Describe the documentation added.> **N/A**
ghost
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
… successfully (open-telemetry#35520) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> If `Input::read` returns 0, the operator will attempt to open the subscription again. This happens after a resubscribe *or* whenever there are no event logs to read, which is often. As a result, this error gets logged constantly: ``` "Failed to re-open subscription for remote server"..."error: subscription handle is already open" ``` To fix this, the handle should only attempt to re-open when the resubscribe happens. This is a followup to open-telemetry#35175 which fixed that resubscribe issue for the user that raised it, but they have also been confused by this error being logged. **Link to tracking Issue:** <Issue number if applicable> **N/A** **Testing:** <Describe what testing was performed and which tests were added.> Manually verified log collection is successful before and after remote host reconnects, and that the noisy error is silenced except during resubscribe, where it is relevant. **Documentation:** <Describe the documentation added.> **N/A**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If
Input::readreturns 0, the operator will attempt to open the subscription again. This happens after a resubscribe or whenever there are no event logs to read, which is often. As a result, this error gets logged constantly:To fix this, the handle should only attempt to re-open when the resubscribe happens.
This is a followup to #35175 which fixed that resubscribe issue for the user that raised it, but they have also been confused by this error being logged.
Link to tracking Issue: N/A
Testing: Manually verified log collection is successful before and after remote host reconnects, and that the noisy error is silenced except during resubscribe, where it is relevant.
Documentation: N/A