[processor/tailsampling] Fixed sampling policy evaluation debug logging batch metrics #37040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
jpkrohling
approved these changes
Jan 7, 2025
jpkrohling
changed the title
jpkrohling
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
I think this would deserve a new test, to avoid a regression, but I'm OK merging this as is, given that this is only used in a debug logging at the moment. Let me know what you prefer, @portertech.
Signed-off-by: Sean Porter <[email protected]>
|
@jpkrohling Thank you for the review! I added a test, is that what you had imagined? |
jpkrohling
approved these changes
Jan 8, 2025
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…ng batch metrics (open-telemetry#37040) #### Description Currently, the processor always logs (at debug) `sampled=0` and `notSampled=0` for every batch processed. This pull-request fixes those metrics. --------- Signed-off-by: Sean Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the processor always logs (at debug)
sampled=0andnotSampled=0for every batch processed. This pull-request fixes those metrics.