Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/tcpcheck] Add New Receiver#34458 #37556

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chengchuanpeng
Copy link

@chengchuanpeng chengchuanpeng commented Jan 28, 2025

Signed-off-by: huangyanfeng [email protected], chengchuanpeng [email protected],

This PR builds upon the work from @yanfeng1992. We really appreciate the effort and thought he put into the original implementation, which laid the groundwork for this update. While there were some changes needed, his contribution was instrumental in guiding the direction of this PR

Description:

To monitor the availability and performance of TCP endpoints.
Use case: TCP network detection plug-in, usually used to monitor whether a TCP port on the local machine is listening, or whether a remote port can be connected

Link to tracking Issue:

#34414

Testing:
(1) PR Includes coverage ~85% in the package with the scraper.
(2) Also includes coverage ~80% in the internal/configtcp package

Documentation:

The new receiver includes documentation in receiver/tcpcheckreceiver/README.md and receiver/tcpcheckreceiver/documentation.md.

Copy link

linux-foundation-easycla bot commented Jan 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@chengchuanpeng
Copy link
Author

chengchuanpeng commented Feb 4, 2025

@yanfeng1992 To add you as a code owner for running pipeline checks, could you create a new PR for membership? Thanks! Here’s an example: link

@github-actions github-actions bot added cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol cmd/telemetrygen telemetrygen command labels Feb 8, 2025
@github-actions github-actions bot requested a review from Erog38 February 8, 2025 00:38
@chengchuanpeng
Copy link
Author

chengchuanpeng commented Feb 8, 2025

I am sorry for the mistake earlier. I've cleaned up my commits and reopened the PR. However, I accidentally included other commits, which unintentionally involved multiple people.

@atoulme atoulme reopened this Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 53.54449% with 308 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (bfe79f6) to head (27d7b03).
Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
cmd/telemetrygen/pkg/logs/logs.go 8.88% 39 Missing and 2 partials ⚠️
cmd/telemetrygen/pkg/metrics/metrics.go 8.88% 39 Missing and 2 partials ⚠️
.../internal/operationsmanagement/metrics_producer.go 76.57% 29 Missing and 12 partials ⚠️
cmd/telemetrygen/internal/common/config.go 0.00% 29 Missing ⚠️
cmd/telemetrygen/pkg/traces/config.go 15.15% 28 Missing ⚠️
...connector/internal/metadata/generated_telemetry.go 0.00% 25 Missing and 1 partial ⚠️
cmd/telemetrygen/pkg/logs/config.go 35.13% 24 Missing ⚠️
cmd/telemetrygen/pkg/metrics/config.go 0.00% 18 Missing ⚠️
...er/internal/operationsmanagement/metrics_client.go 73.07% 10 Missing and 4 partials ⚠️
exporter/bmchelixexporter/exporter_metrics.go 68.42% 9 Missing and 3 partials ⚠️
... and 11 more

❌ Your patch check has failed because the patch coverage (53.54%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (79.62%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37556      +/-   ##
==========================================
+ Coverage   79.58%   79.62%   +0.03%     
==========================================
  Files        2292     2314      +22     
  Lines      213536   216777    +3241     
==========================================
+ Hits       169939   172601    +2662     
- Misses      37893    38415     +522     
- Partials     5704     5761      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[receiver/tcpcheck] Change CODEOWNERS#34458

[receiver/tcpcheck] Change CODEOWNERS#34458

[receiver/tcpcheck] Make Fmt#34458

[receiver/tcpcheck] Fix Version And Test#34458

[receiver/tcpcheck] Make Fmt#34458

[receiver/tcpcheck] Temporarily Change Owner#34458

[receiver/tcpcheck] Change Version#34458

[receiver/tcpcheck] Make Fmt#34458

[receiver/tcpcheck] Rebase#34458

[receiver/tcpcheck] Fix Test#34458

[receiver/tcpcheck] Make Tidy#34458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants