Updated SAPM exporter dependencies #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
bogdandrutu,
flands,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
owais
commented
Dec 11, 2019
| github.com/stretchr/testify v1.4.0 | ||
| go.uber.org/atomic v1.5.1 // indirect | ||
| go.uber.org/multierr v1.4.0 // indirect | ||
| go.uber.org/zap v1.13.0 | ||
| google.golang.org/genproto v0.0.0-20191115221424-83cc0476cb11 // indirect |
There was a problem hiding this comment.
go mod tidy added this. Go is seeing this as a dependency of sapm-proto. This is not a big deal but I'll look into it later. For sapm-proto, this should really be a build dependency and not pulled in here.
tigrannajaryan
approved these changes
Dec 11, 2019
|
Can someone please merge this? @tigrannajaryan @pjanotti |
|
We need one more review to merge this. |
|
@owais please rebase and resolve merge conflicts. |
|
Done |
pjanotti
pushed a commit
that referenced
this pull request
Dec 16, 2019
* initial def of aws xray exporter * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of export handler * fix formatting and lint errors * initial dev of export handler * added to component list * fix issues raised during code review * switch user attribute name to constant * fixed additional code review issues * fixed additional code review issues * temporarily change package name * temporarily change package name * revert temporarily change package name * fixed additional code review issues * switched to constants defined in collector * switched to status conversion functions defined in collector * fix latest code review issues * fix new static check issues * fix test that breaks if no valid aws session available * Update Collector Core dependency to latest `master` (#61) - Updated go.mod and testbed/go.mod to point to latest `master` commit for github.com/open-telemetry/opentelemetry-collector dependencies and fixed the code as needed. - Run `go mod tidy` on both go.mod files. * Ported kinesis exporter from Omnition (#60) Porting the existing kinesis exporter from Omnition's Otel distribution to contrib. Porting from: https://github.com/Omnition/omnition-opentelemetry-collector/tree/master/exporter/kinesis * fix pull request issues * Updated SAPM exporter dependencies (#59) * Add E2E test for SAPM Receiver (#63) - Added DataSender for SAPM protocol. - Added SAPM protocol receiver test to TestTrace10K scenario. * Updated component dependencies (#64) * Fix build for go 1.13 (#65) * Add E2E test for SAPM Exporter (#66) SAPM trace test was using SAPM Receiver and Jaeger Exporter. Now SAPM is used for both ends. * initial def of aws xray exporter * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of xray data structures and converters * initial dev of export handler * fix formatting and lint errors * initial dev of export handler * added to component list * fix issues raised during code review * switch user attribute name to constant * fixed additional code review issues * fixed additional code review issues * temporarily change package name * temporarily change package name * revert temporarily change package name * fixed additional code review issues * switched to constants defined in collector * switched to status conversion functions defined in collector * fix latest code review issues * fix new static check issues * fix test that breaks if no valid aws session available * fix pull request issues
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
This is to make tag.Map an immutable type, so it is safe to use concurrently. The safety is not yet fully achieved because of the functions returning contents of the map (Value and Foreach). The functions give callers an access to core.Value objects, which contain a byte slice, which has pointer like semantics. So to avoid accidental changes, we will need to copy the value if it is of BYTES type. Fixes #59
jj22ee
pushed a commit
to jj22ee/opentelemetry-collector-contrib
that referenced
this pull request
Sep 21, 2023
update readme with suggested ClusterRole rules
carrieedwards
pushed a commit
to grafana/opentelemetry-collector-contrib
that referenced
this pull request
Sep 6, 2024
* Add output verification to TestDatadogMetricsV1_EndToEnd Signed-off-by: Federico Torres <[email protected]> * Add output verification to TestDatadogMetricsV2_EndToEnd Signed-off-by: Federico Torres <[email protected]> * Add output verification to TestDatadogSketches_EndToEnd Signed-off-by: Federico Torres <[email protected]> * Add output verification to TestDatadogServices_EndToEnd Signed-off-by: Federico Torres <[email protected]> * fmt Signed-off-by: Federico Torres <[email protected]> * Refactor output verifications in E2E receiver tests Signed-off-by: Federico Torres <[email protected]> * Add TestConvertBucketLayout Signed-off-by: Federico Torres <[email protected]> * Add TestMapSketchBucketsToHistogramBuckets Signed-off-by: Federico Torres <[email protected]> --------- Signed-off-by: Federico Torres <[email protected]>
edma2
pushed a commit
to edma2/opentelemetry-collector-contrib
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.