Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadogexporter] Skip nil sketches #5925

Merged
merged 1 commit into from
Oct 26, 2021
Merged

[exporter/datadogexporter] Skip nil sketches #5925

merged 1 commit into from
Oct 26, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 26, 2021 •
edited
Loading

Description: Fix nil pointer dereference introduced in #5867.
Testing: Amended unit test to ensure tests check that pointer is not nil

@mx-psi mx-psi requested a review from KSerrania October 26, 2021 16:27
@mx-psi mx-psi marked this pull request as ready for review October 26, 2021 16:46
@mx-psi mx-psi requested review from a team and Aneurysm9 October 26, 2021 16:46
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Oct 26, 2021
@codeboten codeboten merged commit 752067e into open-telemetry:main Oct 26, 2021
@mx-psi mx-psi deleted the mx-psi/fix-nil branch October 26, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSerrania KSerrania KSerrania approved these changes

@codeboten codeboten codeboten approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@anuraaga anuraaga

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mx-psi @codeboten @KSerrania @anuraaga