[exporter/datadog] Move Sanitize functionality into Validate and Unmarshal
#8829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
force-pushed
the
mx-psi/sanitize-validate-unmarshal
branch
from
658ea76 to
4cff6bf
Compare
|
@mx-psi ready for review? |
Yes! I shared this internally so someone from Datadog should review it at some point, but reviews are generally welcome :) |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
djaglowski
reviewed
Jun 9, 2022
There was a problem hiding this comment.
This looks good to me, aside from conflicts that need resolution.
@mx-psi, are you still waiting on internal review?
KSerrania
approved these changes
Jun 10, 2022
|
@djaglowski We have the CODEOWNER review now and the conflicts have been solved :) Could you have a final look? |
djaglowski
approved these changes
Jun 10, 2022
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
…`Unmarshal` (open-telemetry#8829) * [exporter/datadog] Move validation to `Validate` * [exporter/datadog] Move some unmarshaling steps to `Unmarshal`; deprecate `Sanitize` * [exporter/datadog] Move endpoint override logic to `Unmarshal` * [exporter/datadog] Remove unnecessary calls to `Sanitize` * Fix changelog * Update deprecation version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SanitizetoValidateandUnmarshal. In particular:UnmarshalValidateUnmarshalValidateandUnmarshal.Sanitizemethod. Its only use now is logging warnings, and it will be removed once we moveConfigto the main package.This has a minor change on the Go API: right now if one passes a
Configstruct with an empty metrics or traces endpoint, the default one would have been populated bySanitize. After this change, this results in an error. This does not affect end-users of the binary in any way. We can fix this on the future, depending on how the Go API usage evolves, since going from an error to not-an-error is not a breaking change.Link to tracking Issue: relates to #8373
Testing: Added more unit tests for validate and unmarshaling
Documentation: Updated
Sanitizedocs