Porting k8s processor from the Omnition distribution #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
bogdandrutu,
flands,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
tigrannajaryan
approved these changes
Jan 8, 2020
go.mod
Outdated
| replace k8s.io/client-go => k8s.io/client-go v0.0.0-20190620085101-78d2af792bab | ||
|
|
||
| replace github.com/open-telemetry/opentelemetry-collector => github.com/owais/opentelemetry-collector v0.1.1-0.20200108145118-7d7e1c8f7254 |
There was a problem hiding this comment.
Needed for CI until the other PR gets merged upstream
There was a problem hiding this comment.
Please merge this only after upstream is merged and this replacement is removed.
pjanotti
approved these changes
Jan 8, 2020
Introducing a new processor to enable automatic tagging of k8s resources K8S processor discovers running pods in a cluster based on some discovery rules, extracts metadata from such pods using user specified extraction rules, and adds the extracted metadata as attributes to all spans. The processor uses the originating IP address of a pod to determine where the spans are coming from.
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
These 2 functions had error on their return but never returned error. This made confuse on caller sites since it gave the impression that spans could be dropped without proper observability.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
jj22ee
pushed a commit
to jj22ee/opentelemetry-collector-contrib
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new processor to enable automatic tagging of k8s resources
K8S processor discovers running pods in a cluster based on some
discovery rules, extracts metadata from such pods using user specified
extraction rules, and adds the extracted metadata as attributes to all
spans. The processor uses the originating IP address of a pod to determine
where the spans are coming from.
Depends on: open-telemetry/opentelemetry-collector#326