-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/debug] Add option to not use collector's internal logger for output #10226
Comments
Apart from adding this option, I think we should vote on whether we want to change the default behavior. On /issues/5652 I proposed this change, but since:
I still feel like the debug exporter should use the internal logger (but without sampling), but (i) I know there are other people who feel differently here, and (ii) I don't think either side has many arguments other than "this feels like a more intuitive UX". So I feel like we should vote on what we want the default behavior should be (internal logger vs stderr logger). What do you think? |
Preventing a breaking change is perhaps one strong argument to keep the current behavior (which uses internal logger). I'm saying this even though I prefer the other behavior. 🙃 |
I don't have data on this but I assume most users are not explicitly setting the output path for the Collector logger, so the blast radius of a change like this would likely be rather small |
Proposed a pull request to expose the option |
#### Description Adds a new configuration option `use_internal_logger` to the Debug exporter, that makes it possible to prevent unwanted side effects of the exporter using the collector's internal logger. #### Link to tracking issue Fixes #10226 #### Testing Updated unit tests to cover the new config option. #### Documentation Added documentation for the feature. --------- Co-authored-by: Yang Song <[email protected]>
Is your feature request related to a problem? Please describe.
Currently (v0.101.0), the Debug exporter uses the collector's internal logger for output.
This comes with several consequences:
info
level marker, similar to2023-11-10T22:49:03.510-0600 info
{"kind": "exporter", "data_type": "traces", "name": "debug"}
INFO
. This means that if user configures theservice.telemetry.logs.level
toWARN
orERROR
, they will not see the output from the Debug exporter. As a result, it is not possible to configure the collector to see the Debug exporter's output and mute collector's INFO logs at the same time.Describe the solution you'd like
Add configuration option
use_internal_logger
that would make it possible to opt out of using the internal logger and instead use a logger configured separately from the collector's internal logger.Describe alternatives you've considered
The only alternative I see is not use the Debug exporter and instead build a separate exporter for this, or use existing exporter like the File exporter.
The text was updated successfully, but these errors were encountered: