Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bogus service.name used for internal telemetry #10644

Closed
yurishkuro opened this issue Jul 17, 2024 · 1 comment · Fixed by #10645
Closed

Bogus service.name used for internal telemetry #10644

yurishkuro opened this issue Jul 17, 2024 · 1 comment · Fixed by #10645
Labels
bug Something isn't working

Comments

@yurishkuro
Copy link
Member

Describe the bug

When initializing TracerProvider the BuildInfo.Version is used as a service name.

string(semconv.ServiceNameKey): set.BuildInfo.Version,

What did you expect to see?
Assuming that BuildInfo is the right thing to use in the first place, the reasonable mapping would be

  • Command -> service.name
  • Version -> service.version

Command: "otelcol",
Description: "OpenTelemetry Collector",
Version: "latest",

What version did you use?
Version: v0.105.0

@mx-psi
Copy link
Member

mx-psi commented Jul 18, 2024

The proposed change makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants