Skip to content

Commit

Permalink
[telemetry] Use Command/Version to populate service name/version attr…
Browse files Browse the repository at this point in the history
…ibutes (#10645)

#### Link to tracking issue
Fixes #10644

---------

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Jul 18, 2024
1 parent fbadc23 commit eae7b9c
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
25 changes: 25 additions & 0 deletions .chloggen/telemetry-service-name.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: 'bug_fix'

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: 'service'

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Use Command/Version to populate service name/version attributes

# One or more tracking issues or pull requests related to the change
issues: [10644]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: ['user']
3 changes: 2 additions & 1 deletion service/telemetry/tracer.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ var (
// New creates a new Telemetry from Config.
func newTracerProvider(ctx context.Context, set Settings, cfg Config) (trace.TracerProvider, error) {
attrs := map[string]interface{}{
string(semconv.ServiceNameKey): set.BuildInfo.Version,
string(semconv.ServiceNameKey): set.BuildInfo.Command,
string(semconv.ServiceVersionKey): set.BuildInfo.Version,
}
for k, v := range cfg.Resource {
if v != nil {
Expand Down

0 comments on commit eae7b9c

Please sign in to comment.