-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3rd-party LICENSE files to Docker Image distribution #2458
Labels
Comments
There are two tools I think could be really helpful here:
|
Is it worth broadening this issue to include tooling that collector distributions (i.e. bundling some set of out-of-tree plugins) can use to generate and bundle a valid LICENSE file? |
As mentioned in the PR, this would be a great fit for the builder. |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this issue
Apr 27, 2023
The collector downloads the Java agent for instrumentation. The java agent download link is incorrect when a specific tag is provided. This fixes the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Many OSS licenses require re-distribution with said license. E.g. the MIT licenses explicitly states:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
Describe the solution you'd like
We create a
licenses/
directory in the relevant distributed DOCKER files that contains all 3p licenses.Ideally the following would work:
(Note: I can submit a PR).
Describe alternatives you've considered
I didn't consider other alternatives to distributing the license. I guess you could encode it in the binary and dump it in logs at startup?
The text was updated successfully, but these errors were encountered: