Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3rd-party LICENSE files to Docker Image distribution #2458

Closed
jsuereth opened this issue Feb 10, 2021 · 4 comments
Closed

Add 3rd-party LICENSE files to Docker Image distribution #2458

jsuereth opened this issue Feb 10, 2021 · 4 comments
Assignees

Comments

@jsuereth
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Many OSS licenses require re-distribution with said license. E.g. the MIT licenses explicitly states:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

Describe the solution you'd like
We create a licenses/ directory in the relevant distributed DOCKER files that contains all 3p licenses.

Ideally the following would work:

docker create --name="tmp_collector" otel/opentelemetry-collector
docker export tmp_collector | tar -x licenses
docker rm tmp_collector
cat licenses/*

(Note: I can submit a PR).

Describe alternatives you've considered
I didn't consider other alternatives to distributing the license. I guess you could encode it in the binary and dump it in logs at startup?

@jsuereth
Copy link
Contributor Author

There are two tools I think could be really helpful here:

  1. Pivotal's license finder
    • It allows you to opt-in to copy-left license and approve/disallow any the community is uncomfortable with
    • It's highly configurable / flexible
    • It drops an "authorization" report on what decisions were made
    • Available as a docker image
  2. Google's go license finder
  • Dead simple
  • Encodes google's notions of allowable licenses (we can ignore that feature)

@punya
Copy link
Member

punya commented Feb 16, 2021

Is it worth broadening this issue to include tooling that collector distributions (i.e. bundling some set of out-of-tree plugins) can use to generate and bundle a valid LICENSE file?

@jrcamp
Copy link
Contributor

jrcamp commented Mar 10, 2021

@alolita

@jrcamp jrcamp added the priority:p2 Medium label Mar 10, 2021
@jsuereth jsuereth self-assigned this Sep 17, 2021
@jpkrohling
Copy link
Member

As mentioned in the PR, this would be a great fit for the builder.

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
The collector downloads the Java agent for instrumentation. The
java agent download link is incorrect when a specific tag is
provided. This fixes the link.
@github-actions github-actions bot added the Stale label Dec 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants