-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pprofile wrapper and testdata #10401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dmathieu
force-pushed
the
pprofile-wrapper
branch
14 times, most recently
from
June 17, 2024 10:05
5c00039
to
7396769
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10401 +/- ##
==========================================
- Coverage 92.46% 92.38% -0.09%
==========================================
Files 390 392 +2
Lines 18461 18494 +33
==========================================
+ Hits 17070 17085 +15
- Misses 1036 1054 +18
Partials 355 355 ☔ View full report in Codecov by Sentry. |
dmathieu
force-pushed
the
pprofile-wrapper
branch
2 times, most recently
from
June 17, 2024 10:17
0ea9784
to
150f9c1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
dmathieu
force-pushed
the
pprofile-wrapper
branch
from
June 17, 2024 11:38
150f9c1
to
17efb27
Compare
mx-psi
reviewed
Jun 20, 2024
dmathieu
force-pushed
the
pprofile-wrapper
branch
2 times, most recently
from
June 20, 2024 12:46
faa4c92
to
892d8f3
Compare
mx-psi
approved these changes
Jun 24, 2024
Co-authored-by: Pablo Baeyens <[email protected]>
mx-psi
added
Skip Changelog
PRs that do not require a CHANGELOG.md entry
and removed
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds pprofile wrapper (the non-generated bit of pprofile), as well as test data.
cc @mx-psi