[otelcol] Remove all default providers/converters #10436
Conversation
TylerHelmuth
force-pushed
the
otelcol-update-commane
branch
from
3053801 to
99dfa08
Compare
TylerHelmuth
force-pushed
the
otelcol-update-commane
branch
from
99dfa08 to
ce55ff2
Compare
|
I'm planning to submit another PR to jaeger to handle the deprecation process, was waiting for the 0.103.0 release to finish in Contrib. I've already update Jaeger to pass in providers. |
|
Jaeger is updated: jaegertracing/jaeger#5657 |
| @@ -258,6 +258,8 @@ func TestGenerateAndCompile(t *testing.T) { | |||
| testCase: "Default Configuration Compilation", | |||
| cfgBuilder: func(t *testing.T) Config { | |||
| cfg := newTestConfig() | |||
| err := cfg.SetBackwardsCompatibility() | |||
There was a problem hiding this comment.
These tests all pass in a list of providers, and therefore depend on those providers in the go mod list. The builder templates only add them when .Distribution.SupportsConfmapFactories is true. That value was not being set so all these tests should have been failing. They were saved instead by the fact that otelcol depended on the providers. The changes in this PR remove those dependencies when otelcoltest is not being used, so these tests started failing. The fix was to make sure .Distribution.SupportsConfmapFactories is true, which is included in cfg.SetBackwardsCompatibility().
There was a problem hiding this comment.
Nice catch, thanks for the explanation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10436 +/- ##
==========================================
- Coverage 92.40% 92.40% -0.01%
==========================================
Files 393 393
Lines 18584 18567 -17
==========================================
- Hits 17173 17156 -17
Misses 1056 1056
Partials 355 355 ☔ View full report in Codecov by Sentry. |
|
@TylerHelmuth can you resolve the conflict? |
|
@mx-psi conflict handled. |
|
@evan-bradley will merge this by Friday EU morning unless you comment by then! |
|
Sorry, I was out last week, thanks for not holding this up on me. This looks good to me, the negative diff in the go.mod file is a win in my eyes. |
|
Agreed, I am pretty happy about the |
Description
Removed deprecated
NewCommand. DeprecatesNewCommandMustSetProvider. AddsNewCommandthat requires at least one provider be set.Removes usage of imported providers/converters from otelcol (but they still live in otelcoltest until #10417 is merged.
Link to tracking issue
closes #10290.
Testing
Unit tests