[chore] rely on strict input parsing to error out on invalid unsigned int values #10609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
remove_todo_confmap
branch
from
a0a8a9e to
ca47f3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10609 +/- ##
==========================================
- Coverage 91.68% 91.68% -0.01%
==========================================
Files 404 404
Lines 18953 18947 -6
==========================================
- Hits 17377 17371 -6
Misses 1217 1217
Partials 359 359 ☔ View full report in Codecov by Sentry. |
mx-psi
reviewed
Jul 15, 2024
|
True, maybe need to wait for the feature gate to be stable. This TODO is going to block confmap 1.0. |
mx-psi
pushed a commit
that referenced
this pull request
Jul 19, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Blocked by #10793 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
approved these changes
Aug 20, 2024
github-actions
bot
modified the milestones:
go.opentelemetry.io/collector/confmap 1.0,
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a hook for confmap that was used to handle invalid uint values, now that #9532 is fixed.