Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][samplereceiver] Update internal telemetry metric units #10672

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

crobert-1
Copy link
Member

Description

Update telemetry units to be more clear. Related to #10658, we may be blocked here waiting for official units to use.

Note: I've kept one metric with the unit "1", as it's not meant to be meaningful, just to show a metric that's disabled by default.

Since this code is internal and only used for tests, from what I can tell, I don't believe we need a changelog entry.

Link to tracking issue

Fixes #10653

@crobert-1 crobert-1 requested review from a team and dmitryax July 19, 2024 22:09
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some tests will need to be updated

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (458c4f9) to head (09b69a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10672   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         401      401           
  Lines       18786    18786           
=======================================
  Hits        17316    17316           
  Misses       1110     1110           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 2125fe8 into open-telemetry:main Jul 30, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 30, 2024
@crobert-1 crobert-1 deleted the samplereceiver_units branch July 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review metadata.yaml units for internal telemetry: cmd/mdatagen/internal/samplereceiver
2 participants