Improve Error Handling in BatchSender Test #12178
Open
+41
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalgaud12
requested review from
bogdandrutu,
dmitryax and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12178 +/- ##
=======================================
Coverage 91.75% 91.75%
=======================================
Files 464 464
Lines 24763 24763
=======================================
Hits 22722 22722
Misses 1656 1656
Partials 385 385 ☔ View full report in Codecov by Sentry. |
sonalgaud12
force-pushed
the
error-handling
branch
from
990c6cd to
3eb7148
Compare
sonalgaud12
force-pushed
the
error-handling
branch
from
3eb7148 to
54af44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves error handling and robustness in the
TestBatchSender_InvalidMergeSplitFunctest, which was flaky on Windows due to timing and asynchronous issues. The changes ensure more reliable test execution by introducing explicit error checks and additional assertions for request and item counts. It also adds better logging and robust timeout handling.Link to tracking issue
Fixes #10841