Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix govulncheck related to crypto/x509 #12197

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

bogdandrutu
Copy link
Member

Vulnerability #1: GO-2025-3373
Usage of IPv6 zone IDs can bypass URI name constraints in crypto/x509
More info: https://pkg.go.dev/vuln/GO-2025-3373
Standard library
Found in: crypto/[email protected].10
Fixed in: crypto/[email protected].11

@bogdandrutu bogdandrutu requested a review from a team as a code owner January 28, 2025 04:12
@bogdandrutu bogdandrutu requested a review from mx-psi January 28, 2025 04:12
@bogdandrutu bogdandrutu added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (c4f1c3f) to head (8b4c558).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12197   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         465      465           
  Lines       25325    25325           
=======================================
  Hits        23261    23261           
  Misses       1675     1675           
  Partials      389      389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu enabled auto-merge January 28, 2025 04:24
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 28, 2025
Merged via the queue into open-telemetry:main with commit 9a4f3c0 Jan 28, 2025
65 of 78 checks passed
@bogdandrutu bogdandrutu deleted the fix-vulnera branch January 28, 2025 05:01
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jan 28, 2025
#### Description

Vulnerability #1: GO-2025-3420
Sensitive headers incorrectly sent after cross-domain redirect in
net/http
  More info: https://pkg.go.dev/vuln/GO-2025-3420
  Standard library
    Found in: net/[email protected]
    Fixed in: net/[email protected]
    Example traces found:
Error: #1: codeowners.go:212:55:
githubgen.codeownersGenerator.getGithubMembers calls
github.OrganizationsService.ListMembers, which eventually calls
http.Client.Do

Vulnerability #2:
GO-[20](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13003223509/job/36265594395?pr=37492#step:6:21)25-3373
Usage of IPv6 zone IDs can bypass URI name constraints in crypto/x509
  More info: https://pkg.go.dev/vuln/GO-2025-3373
  Standard library
Found in:
crypto/x509@go1.[22](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13003223509/job/36265594395?pr=37492#step:6:23).8
    Fixed in: crypto/[email protected]
    Example traces found:

Related:
open-telemetry/opentelemetry-collector#12197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants