Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetricsWrapper to dissallow access to internal representation #2693

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 13, 2021 20:28
@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #2693 (84da83b) into main (df9f565) will decrease coverage by 0.00%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2693      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files         289      289              
  Lines       15541    15532       -9     
==========================================
- Hits        14274    14265       -9     
  Misses        870      870              
  Partials      397      397              
Impacted Files Coverage Δ
exporter/otlpexporter/otlp.go 69.86% <50.00%> (-0.41%) ⬇️
consumer/pdata/metric.go 99.23% <100.00%> (-0.05%) ⬇️
exporter/fileexporter/file_exporter.go 80.00% <100.00%> (-2.36%) ⬇️
exporter/prometheusremotewriteexporter/exporter.go 89.26% <100.00%> (ø)
internal/otlp_wrapper.go 100.00% <100.00%> (ø)
receiver/otlpreceiver/metrics/otlp.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9f565...84da83b. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 43f131a into open-telemetry:main Mar 17, 2021
@bogdandrutu bogdandrutu deleted the metricswrapper branch March 17, 2021 17:44
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants