-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jaeger receiver to honor TLS config #2866
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2866 +/- ##
==========================================
- Coverage 91.61% 91.60% -0.01%
==========================================
Files 312 312
Lines 15437 15434 -3
==========================================
- Hits 14143 14139 -4
- Misses 884 885 +1
Partials 410 410
Continue to review full report at Codecov.
|
The Is it possible to fit that into this receiver? |
Looks doable, just need to make sure |
@keitwb I think it also makes sense to use |
Yeah I agree, a different PR. |
@tigrannajaryan can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks good to me, but haven't there been any changes to the docs?
53b1eaa
to
4ba131c
Compare
@jpkrohling As I see TLS configuration is already described here: |
4ba131c
to
a02c997
Compare
Add missing TLSConfig into jaeger reciever's configuration. Create TLS listener if TLS config is passed. Signed-off-by: Daniil Rutskiy <[email protected]>
Signed-off-by: Daniil Rutskiy <[email protected]>
Signed-off-by: Daniil Rutskiy <[email protected]>
Signed-off-by: Daniil Rutskiy <[email protected]>
Signed-off-by: Daniil Rutskiy <[email protected]>
a02c997
to
67e69d9
Compare
…-agent/pkg/apm (open-telemetry#2866) * Bump github.com/stretchr/testify in /pkg/signalfx-agent/pkg/apm Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.1...v1.8.2) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * make tidy --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jeffreyc-splunk <[email protected]>
Description:
Add missing TLSConfig into the jaeger receiver's configuration.
Create TLS listener if TLS config is passed.
Link to tracking Issue: #2850