Wait jaeger receiver server goroutines exit on shutdown #2985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test hitting #2975 runs Start and Shutdown in close succession and in this case Shutdown was setting the field
collectorServer
to nil before the goroutine launched on Start actually accessed the field. Fixed the issue by adding async.WaitGroup
to ensure that Shutdown actually waits for all launched goroutines to exit (also improved error handling for the server goroutines). Removed setting the fields to nil on Shutdown since that is not necessary.Fixes #2975