Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup internal/testcomponents #5522

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jun 13, 2022

  • Expose example processor to allow start/shutdown tests.

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan June 13, 2022 14:27
@bogdandrutu
Copy link
Member Author

This is first PR from #5512

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #5522 (70b49e2) into main (e5ac6d2) will increase coverage by 0.01%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##             main    #5522      +/-   ##
==========================================
+ Coverage   90.88%   90.90%   +0.01%     
==========================================
  Files         191      191              
  Lines       11378    11381       +3     
==========================================
+ Hits        10341    10346       +5     
+ Misses        812      811       -1     
+ Partials      225      224       -1     
Impacted Files Coverage Δ
internal/testcomponents/example_processor.go 88.88% <88.88%> (+1.38%) ⬆️
internal/testcomponents/example_exporter.go 100.00% <100.00%> (ø)
internal/testcomponents/example_factories.go 100.00% <100.00%> (+60.00%) ⬆️
internal/testcomponents/example_receiver.go 100.00% <100.00%> (ø)
pdata/internal/common.go 94.61% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ac6d2...70b49e2. Read the comment docs.

* Remove unnecessary types.
* Expose example processor to allow start/shutdown tests.

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu merged commit a88d448 into open-telemetry:main Jun 14, 2022
@bogdandrutu bogdandrutu deleted the examplecomp branch June 14, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants