Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split receiver into its own module #7195

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Feb 13, 2023

Adds the receiver component as its own module.

Fixes #7174

Signed-off-by: Alex Boten [email protected]

@codeboten codeboten force-pushed the codeboten/split-receiver branch from 05c0154 to 72b5cbb Compare February 24, 2023 17:57
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 90.99% // Head: 90.99% // No change to project coverage 👍

Coverage data is based on head (764477d) compared to base (6f800ca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7195   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         293      293           
  Lines       14268    14268           
=======================================
  Hits        12983    12983           
  Misses       1017     1017           
  Partials      268      268           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten force-pushed the codeboten/split-receiver branch from 72b5cbb to a0a2367 Compare February 24, 2023 18:06
Adds the receiver component as its own module.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/split-receiver branch from a0a2367 to f794f8c Compare February 24, 2023 18:15
@codeboten codeboten marked this pull request as ready for review February 24, 2023 18:15
@codeboten codeboten requested review from a team and dmitryax February 24, 2023 18:15
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeboten codeboten merged commit 4071a47 into open-telemetry:main Mar 2, 2023
@codeboten codeboten deleted the codeboten/split-receiver branch March 2, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split core into more granular modules: receiver
3 participants