Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] bump go-grpc-compression #7863

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Jun 9, 2023

This address an issue where zstd compression causes significant memory pressure. Fixes #7862

@codeboten codeboten requested review from a team and jpkrohling June 9, 2023 15:23
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (880e47c) 91.14% compared to head (75ffc9f) 91.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7863   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         298      298           
  Lines       14915    14915           
=======================================
  Hits        13594    13594           
  Misses       1045     1045           
  Partials      276      276           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu
Copy link
Member

@codeboten need a rebase

@codeboten
Copy link
Contributor Author

@bogdandrutu needs more than a rebase. The dependency on otelgrpc instrumentation causes an ambiguous import, which I don't think we can address until the instrumentation is updated.

@bogdandrutu
Copy link
Member

@codeboten you can add a replace cloud.google.com/go/compute/metadata -> ...

@codeboten
Copy link
Contributor Author

@bogdandrutu but this replace would need to be in the builder configuration for anyone building the collector w/ the otlp exporter right?

@bogdandrutu
Copy link
Member

@bogdandrutu but this replace would need to be in the builder configuration for anyone building the collector w/ the otlp exporter right?

Until the thing is fixed upstream we can hardcode in the builder as one of the replacements always?

Alex Boten added 2 commits June 12, 2023 16:43
This helps address an issue where zstd compression causes significant memory pressure. Fixes open-telemetry#7862

Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/bump-go-grpc-compression branch from 0c61adf to 75ffc9f Compare June 12, 2023 23:50
@codeboten codeboten merged commit 45d9a9e into open-telemetry:main Jun 13, 2023
@codeboten codeboten deleted the codeboten/bump-go-grpc-compression branch June 13, 2023 15:48
@github-actions github-actions bot added this to the next release milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory footprint grows significantly with zstd compression
2 participants