Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Ensure test service eventually connects to telemetry port on restart #7893

Merged

Conversation

MovieStoreGuy
Copy link
Contributor

Description:

There appears to be a flake in waiting for resources being released within tests:

    service_test.go:345: 
        	Error Trace:	/home/runner/work/opentelemetry-collector/opentelemetry-collector/service/service_test.go:345
        	Error:      	Received unexpected error:
        	            	Get "http://localhost:8888/metrics": dial tcp [::1]:8888: connect: connection refused
        	Test:       	TestServiceTelemetryRestart

See test run: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/5267677421/jobs/9523273917?pr=7703

Link to tracking Issue:

NA

Testing:
NA

Documentation:
NA

@MovieStoreGuy MovieStoreGuy requested review from a team and jpkrohling June 14, 2023 13:48
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (45d9a9e) 91.14% compared to head (de1cd6e) 91.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7893   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files         298      298           
  Lines       14915    14915           
=======================================
  Hits        13594    13594           
  Misses       1045     1045           
  Partials      276      276           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 14, 2023
@codeboten codeboten merged commit 13242c3 into open-telemetry:main Jun 14, 2023
@github-actions github-actions bot added this to the next release milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants