Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split config/configopaque into its own module #7906

Merged

Conversation

codeboten
Copy link
Contributor

Part of #7895

Follow up to #7905

@codeboten codeboten force-pushed the codeboten/split-config-mod-opaque branch 2 times, most recently from 381e3b7 to 95bb54c Compare June 15, 2023 22:50
@jpkrohling
Copy link
Member

I reviewed only the last two commits from this PR. The other ones were reviewed in the PR this was initially based on.

Alex Boten added 3 commits June 16, 2023 11:16
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/split-config-mod-opaque branch from 95bb54c to 2b6a3ee Compare June 16, 2023 18:17
@codeboten codeboten marked this pull request as ready for review June 16, 2023 18:18
@codeboten codeboten requested review from a team and mx-psi June 16, 2023 18:18
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c76fce7) 91.12% compared to head (2b6a3ee) 91.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7906   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         298      298           
  Lines       14912    14912           
=======================================
  Hits        13589    13589           
  Misses       1047     1047           
  Partials      276      276           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten merged commit 084a64e into open-telemetry:main Jun 16, 2023
@codeboten codeboten deleted the codeboten/split-config-mod-opaque branch June 16, 2023 18:50
@github-actions github-actions bot added this to the next release milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants