Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split config/configtelemetry into its own module #7908

Merged

Conversation

codeboten
Copy link
Contributor

Part of #7895

Follow up to #7907

@codeboten codeboten force-pushed the codeboten/split-config-mod-telemetry branch from ecd8b42 to d720e8e Compare June 15, 2023 22:51
@@ -4,7 +4,7 @@ go 1.19

require (
github.com/stretchr/testify v1.8.4
go.opentelemetry.io/collector v0.79.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice clean up!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is!

@codeboten codeboten force-pushed the codeboten/split-config-mod-telemetry branch from d720e8e to 52a2503 Compare June 16, 2023 19:06
@codeboten codeboten marked this pull request as ready for review June 16, 2023 19:06
@codeboten codeboten requested review from a team and Aneurysm9 June 16, 2023 19:06
@codeboten codeboten force-pushed the codeboten/split-config-mod-telemetry branch from 8140f4f to ec26510 Compare June 16, 2023 19:13
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@ca22f12). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7908   +/-   ##
=======================================
  Coverage        ?   91.16%           
=======================================
  Files           ?      298           
  Lines           ?    14912           
  Branches        ?        0           
=======================================
  Hits            ?    13594           
  Misses          ?     1042           
  Partials        ?      276           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten merged commit f482916 into open-telemetry:main Jun 16, 2023
@github-actions github-actions bot added this to the next release milestone Jun 16, 2023
@codeboten codeboten deleted the codeboten/split-config-mod-telemetry branch June 16, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants