Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporterhelper] fix bug with queue size and capacity metrics #8716

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[exporterhelper] fix bug with queue size and capacity metrics #8716

merged 2 commits into from
Oct 26, 2023

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Oct 20, 2023 •
edited
Loading

This change ensures the queue_size and queue_capacity metrics are available when using OpenTelemetry for the collector's internal metrics.

Fixes #8682

@codeboten codeboten force-pushed the codeboten/fix-queue-size-metric branch from fd44472 to 99c78a6 Compare October 23, 2023 22:12
@codeboten codeboten marked this pull request as ready for review October 23, 2023 22:13
@codeboten codeboten requested review from a team and jpkrohling October 23, 2023 22:13
@codeboten codeboten force-pushed the codeboten/fix-queue-size-metric branch from 99c78a6 to 7e6dac1 Compare October 25, 2023 19:02
codeboten
codeboten commented Oct 25, 2023
View reviewed changes
Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR follows #8758, i ran into issues with the otel/oc paths being tested with the same oc handler

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files Coverage Δ
exporter/exporterhelper/queue_sender.go 95.89% <100.00%> (+1.10%) ⬆️
obsreport/obsreporttest/obsreporttest.go 78.48% <0.00%> (-2.04%) ⬇️
obsreport/obsreporttest/otelprometheuschecker.go 78.03% <0.00%> (-9.26%) ⬇️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[exporterhelper] fix bug with queue size and capacity metrics
bbb5978 
This change ensures the queue_size and queue_capacity metrics are available when using OpenTelemetry for the collector's internal metrics.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/fix-queue-size-metric branch from 4b27dfa to bbb5978 Compare October 25, 2023 20:37
@codeboten codeboten merged commit f0bba0e into open-telemetry:main Oct 26, 2023
@codeboten codeboten deleted the codeboten/fix-queue-size-metric branch October 26, 2023 15:06
@github-actions github-actions bot added this to the next release milestone Oct 26, 2023
@codeboten codeboten mentioned this pull request Dec 13, 2023
Closed
@codeboten codeboten mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.89.0
Development

Successfully merging this pull request may close these issues.

queue_size & queue_capacity gauges not available in otel metrics
3 participants
@codeboten @jpkrohling @dmitryax