Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx instrumentation #494

Merged
merged 18 commits into from
Nov 29, 2024
Merged

Update nginx instrumentation #494

merged 18 commits into from
Nov 29, 2024

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Nov 28, 2024

  • Works with latest nginx versions.
  • Removed toml configuration, everything is configurable from the nginx configuration and/or environment variables now.
  • Replaced gRPC with OTLP over HTTP - reduces the amount of dependencies needed to build.
  • Updated the buids and CI to test and build binaries on different Linux distros.
  • New nginx directives due to the removal of toml configuration: opentelemetry_service_name, opentelemetry_span_processor, opentelemetry_otlp_traces_endpoint, opentelemetry_traces_sampler, opentelemetry_traces_sampler_ratio, opentelemetry_bsp_schedule_delay_millis, opentelemetry_bsp_max_export_batch_size, opentelemetry_bsp_max_queue_size.

@seemk seemk marked this pull request as ready for review November 29, 2024 12:57
@seemk seemk requested review from tobiasstadler and a team as code owners November 29, 2024 12:57
@seemk
Copy link
Contributor Author

seemk commented Nov 29, 2024

@tobiasstadler Not sure if you're still around, but will need an approval to merge it.

@lalitb If no approver is around, can I have an approval? Going to do additional updates (and go over the open issues).

@seemk seemk changed the title [DRAFT] Update nginx instrumentation Update nginx instrumentation Nov 29, 2024
@seemk seemk merged commit 0bf4ec5 into open-telemetry:main Nov 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants