Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Build break with old curl, macro CURL_VERSION_BITS unknown #2101

Closed
marcalff opened this issue Apr 19, 2023 · 0 comments · Fixed by #2102
Closed

[BUILD] Build break with old curl, macro CURL_VERSION_BITS unknown #2101

marcalff opened this issue Apr 19, 2023 · 0 comments · Fixed by #2102
Assignees
@marcalff
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

When compiling code that depends on CURL, like the OTLP HTTP exporter, the build fails for old curl.

The issue is that file:
ext/src/http/client/curl/http_operation_curl.cc
contains uses of the CURL macro CURL_VERSION_BITS.

This macro was introduced only in CURL 7.43.0, so building with older curl breaks.

Fix:

  • Keep using CURL_VERSION_BITS for readability
  • define the macro if missing.

Curl commit that introduced this macro:

commit 39b9bf60d13ff7cb62a6a031c210d27a32113c4f
Author: Daniel Stenberg <[email protected]>
Date:   Thu May 14 23:33:27 2015 +0200

    curlver: introducing new version number (checking) macros
@marcalff marcalff added the bug Something isn't working label Apr 19, 2023
@marcalff marcalff self-assigned this Apr 19, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Apr 19, 2023
@marcalff
Fix open-telemetry#2101
4df4f40
@marcalff marcalff mentioned this issue Apr 19, 2023
Merged
3 tasks
marcalff added a commit that referenced this issue Apr 19, 2023
@marcalff
[BUILD] Build break with old curl, macro CURL_VERSION_BITS unknown (#…
82f2828 
…2102)

Fix #2101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Build break with old curl, macro CURL_VERSION_BITS unknown marcalff/opentelemetry-cpp
1 participant
@marcalff