Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix otlp grpc exporter example in the documentation #1474

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Fix otlp grpc exporter example in the documentation #1474

merged 2 commits into from
Jul 1, 2022

Conversation

lostwong
Copy link
Contributor

@lostwong lostwong commented Jul 1, 2022 •
edited
Loading

The value for opts.endpoint for otlp grpc exporter had an extra colon that would cause an exception if used as is.

Fixes # (issue)

Changes

Minor fix to an example in the opentelemetry-cpp documentation.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lostwong
Fix endpoint in otlp grpc exporter
3566bcf 
The value for `opts.endpoint` for otlp grpc exporter had an extra colon that would cause an exception if used as is.
@lostwong lostwong requested a review from a team July 1, 2022 19:40
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 1, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@lostwong lostwong changed the title Fix endpoint in otlp grpc exporter Fix endpoint example in otlp grpc exporter documentation Jul 1, 2022
@lostwong lostwong changed the title Fix endpoint example in otlp grpc exporter documentation Fix otlp grpc exporter example in the documentation Jul 1, 2022
lalitb
lalitb approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. This was me with the typo 🤦‍♂️

@codecov
Copy link

codecov bot commented Jul 1, 2022 •
edited
Loading

Codecov Report

Merging #1474 (dccf292) into main (e372ce5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1474   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files         154      154           
  Lines        4377     4377           
=======================================
  Hits         3734     3734           
  Misses        643      643

@lalitb lalitb merged commit 9efb7a1 into open-telemetry:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lostwong @ThomsonTan @lalitb