-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OTELCPP_MAINTAINER_MODE #1844
Merged
lalitb
merged 6 commits into
open-telemetry:main
from
marcalff:fix_maintainer_mode_compiler
Dec 9, 2022
Merged
Fix OTELCPP_MAINTAINER_MODE #1844
lalitb
merged 6 commits into
open-telemetry:main
from
marcalff:fix_maintainer_mode_compiler
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump gcc to version 12 - bump clang to version 14 - expand coverage on W3C tests
ThomsonTan
reviewed
Dec 5, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
==========================================
- Coverage 85.79% 85.73% -0.05%
==========================================
Files 171 171
Lines 5240 5240
==========================================
- Hits 4495 4492 -3
- Misses 745 748 +3
|
marcalff
changed the title
Fix MAINTAINER_MODE
[Cleanup in progress] Fix MAINTAINER_MODE
Dec 5, 2022
marcalff
changed the title
[Cleanup in progress] Fix MAINTAINER_MODE
Fix MAINTAINER_MODE
Dec 6, 2022
lalitb
reviewed
Dec 7, 2022
lalitb
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
owent
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
owent
added a commit
to owent/opentelemetry-cpp
that referenced
this pull request
Dec 8, 2022
Signed-off-by: owent <[email protected]>
owent
added a commit
to owent/opentelemetry-cpp
that referenced
this pull request
Dec 8, 2022
Signed-off-by: owent <[email protected]> Merge partly of open-telemetry#1844 Signed-off-by: owent <[email protected]> Update gtest to 1.12.1 by default Signed-off-by: owent <[email protected]> Fix compatibility when using clang and libc++ Signed-off-by: owent <[email protected]>
owent
added a commit
to owent/opentelemetry-cpp
that referenced
this pull request
Dec 9, 2022
Signed-off-by: owent <[email protected]> Merge partly of open-telemetry#1844 Signed-off-by: owent <[email protected]> Update gtest to 1.12.1 by default Signed-off-by: owent <[email protected]> Fix compatibility when using clang and libc++ Signed-off-by: owent <[email protected]>
3 tasks
marcalff
added
the
pr:please-merge
This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
label
Dec 9, 2022
owent
added a commit
to owent/opentelemetry-cpp
that referenced
this pull request
Dec 12, 2022
Signed-off-by: owent <[email protected]> Merge partly of open-telemetry#1844 Signed-off-by: owent <[email protected]> Update gtest to 1.12.1 by default Signed-off-by: owent <[email protected]> Fix compatibility when using clang and libc++ Signed-off-by: owent <[email protected]> No need build local gtest when using legacy toolchain. Signed-off-by: owent <[email protected]> Fix env in sudo Signed-off-by: owent <[email protected]> Add hint to print current C++ standard and stdlib for cmake. Signed-off-by: owent <[email protected]> Print output of C++ environment detection Signed-off-by: owent <[email protected]> Allow to set cxx flags by environments in CI jobs. Signed-off-by: owent <[email protected]> fix MAINTAINER_MODE: - bump gcc to version 12 - bump clang to version 14 - expand coverage on W3C tests Upgrade gootletest 1.12.1 Fixed new warnings. Fixed format, added changelog. Using fallback version of span when `std::span` do not support `range`. Signed-off-by: owent <[email protected]>
owent
added a commit
to owent/opentelemetry-cpp
that referenced
this pull request
Dec 13, 2022
Signed-off-by: owent <[email protected]> Merge partly of open-telemetry#1844 Signed-off-by: owent <[email protected]> Update gtest to 1.12.1 by default Signed-off-by: owent <[email protected]> Fix compatibility when using clang and libc++ Signed-off-by: owent <[email protected]> No need build local gtest when using legacy toolchain. Signed-off-by: owent <[email protected]> Fix env in sudo Signed-off-by: owent <[email protected]> Add hint to print current C++ standard and stdlib for cmake. Signed-off-by: owent <[email protected]> Print output of C++ environment detection Signed-off-by: owent <[email protected]> Allow to set cxx flags by environments in CI jobs. Signed-off-by: owent <[email protected]> fix MAINTAINER_MODE: - bump gcc to version 12 - bump clang to version 14 - expand coverage on W3C tests Upgrade gootletest 1.12.1 Fixed new warnings. Fixed format, added changelog. Using fallback version of span when `std::span` do not support `range`. Signed-off-by: owent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr:please-merge
This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix OTELCPP_MAINTAINER_MODE
Changes
Fix OTELCPP_MAINTAINER_MODE
CHANGELOG.md
updated for non-trivial changes