[SDK] Add tracer scope configurator #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
psx95
force-pushed
the
add-scope-config
branch
from
6e15bc3 to
75d84d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
==========================================
+ Coverage 87.80% 87.91% +0.12%
==========================================
Files 198 201 +3
Lines 6324 6385 +61
==========================================
+ Hits 5552 5613 +61
Misses 772 772
|
psx95
force-pushed
the
add-scope-config
branch
11 times, most recently
from
dd70641 to
0370722
Compare
psx95
force-pushed
the
add-scope-config
branch
2 times, most recently
from
b82ea68 to
f6ff444
Compare
psx95
force-pushed
the
add-scope-config
branch
10 times, most recently
from
93950bf to
c77065e
Compare
psx95
changed the title
marcalff
reviewed
Jan 13, 2025
marcalff
reviewed
Jan 13, 2025
marcalff
reviewed
Jan 13, 2025
marcalff
reviewed
Jan 13, 2025
psx95
force-pushed
the
add-scope-config
branch
from
b382755 to
8511e80
Compare
psx95
force-pushed
the
add-scope-config
branch
from
5b72b3e to
8ef20b2
Compare
fix dangling pointer warnings & valgrind memcheck warnings
psx95
force-pushed
the
add-scope-config
branch
from
8ef20b2 to
98ec24d
Compare
|
Hi @marcalff, |
chusitoo
reviewed
Jan 27, 2025
sdk/include/opentelemetry/sdk/instrumentationscope/scope_configurator.h
Outdated
Show resolved
Hide resolved
chusitoo
reviewed
Jan 27, 2025
sdk/include/opentelemetry/sdk/instrumentationscope/scope_configurator.h
Outdated
Show resolved
Hide resolved
chusitoo
reviewed
Jan 27, 2025
Update string_view -> string for use within the function scope to ensure scope lifetime. Update push_back -> emplace_back to construct directly within the vector container. Added a constructor to the Condition struct to enable emplace_back.
Making builder's methods return reference type prevents unneeded copies of the object.
|
Hi @chusitoo, Please take a look. |
marcalff
approved these changes
Jan 30, 2025
| "accept_third_attr", 3}; | ||
|
|
||
| static instrumentation_scope::InstrumentationScope test_scope_1 = | ||
| *instrumentation_scope::InstrumentationScope::Create("test_scope_1"); |
There was a problem hiding this comment.
It is weird to invoke Create() and then use the object behind the unique ptr, but given how InstrumentationScope does not expose public constructors, this is the best the test can do.
Approved as is then.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2641
Adds scope configurator for Tracers.
Changes
Some optional, good-to-have convenience functions were recommended by the spec to accommodate common use-cases - these have not been added in this PR.
See the TracerConfigurator spec for these recommendations. They should be added in a future PR.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes