Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Build break with CURL 7.29.0 #3255

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

marcalff
Copy link
Member

Fixes #3252

Changes

Please provide a brief description of the changes here.

  • Indicate to include-what-you-use to not include header curl/system.h
  • This fixes the build with CURL 7.29.0, where this header does not exist.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Sorry, something went wrong.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 65f2ea8
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6793c57ce6a3a50008ec6d69

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (72b0080) to head (65f2ea8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3255   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files         198      198           
  Lines        6324     6324           
=======================================
  Hits         5552     5552           
  Misses        772      772           

@marcalff marcalff marked this pull request as ready for review January 24, 2025 20:59
@marcalff marcalff requested a review from a team as a code owner January 24, 2025 20:59
@marcalff marcalff merged commit 18e06f1 into open-telemetry:main Jan 25, 2025
57 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jan 25, 2025
[BUILD] Build break with CURL 7.29.0 (open-telemetry#3255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUILD] Build break with CURL 7.29.0
2 participants