-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resources.ProcessRuntime] Rename processruntime detector namespace #1767
[Resources.ProcessRuntime] Rename processruntime detector namespace #1767
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
- Coverage 73.91% 73.78% -0.14%
==========================================
Files 267 293 +26
Lines 9615 10859 +1244
==========================================
+ Hits 7107 8012 +905
- Misses 2508 2847 +339 Flags with carried forward coverage won't be shown. Click here to find out more.
|
# Conflicts: # .github/ISSUE_TEMPLATE/bug_report.yml # .github/ISSUE_TEMPLATE/feature_request.yml # .github/workflows/ci.yml # opentelemetry-dotnet-contrib.sln
Require update to usage section in Readme, it still uses the old way of enablement which will not work - opentelemetry-dotnet-contrib/src/OpenTelemetry.Resources.ProcessRuntime/README.md Line 29 in bde8864
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (+ nit about the order), could you please resolve conflicts with main - you previous PR?
Changes
Changes are following guidelines in #1610.
AddProcessRuntimeDetector
extension method forResourceBuilder
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes