Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Owin] Remove SDK dependency #1977

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

CodeBlanch
Copy link
Member

Changes

  • Switches Owin to depend on API instead of SDK

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team July 25, 2024 18:24
@github-actions github-actions bot added the comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (71655ce) to head (92fe75c).
Report is 370 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1977       +/-   ##
===========================================
+ Coverage   73.91%   85.79%   +11.88%     
===========================================
  Files         267        8      -259     
  Lines        9615      169     -9446     
===========================================
- Hits         7107      145     -6962     
+ Misses       2508       24     -2484     
Flag Coverage Δ
unittests-Instrumentation.Owin 85.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 269 files with indirect coverage changes

@Kielek Kielek merged commit abcc3d2 into open-telemetry:main Jul 25, 2024
54 checks passed
@CodeBlanch CodeBlanch deleted the owin-api-dependency branch July 25, 2024 19:15
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ezhang6811 pushed a commit to ezhang6811/opentelemetry-dotnet-contrib that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants