Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Owin] Update to semantic convention v1.27.0 #2028

Merged
merged 12 commits into from
Sep 16, 2024

Conversation

ysolomchenko
Copy link
Contributor

@ysolomchenko ysolomchenko commented Aug 29, 2024

Fixes #1949

Changes

Add documentation for OTEL_DOTNET_EXPERIMENTAL_OWIN_DISABLE_URL_QUERY_REDACTION

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ysolomchenko ysolomchenko requested a review from a team August 29, 2024 09:16
@github-actions github-actions bot requested a review from CodeBlanch August 29, 2024 09:16
@github-actions github-actions bot added comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin documentation Improvements or additions to documentation labels Aug 29, 2024
@ysolomchenko ysolomchenko marked this pull request as draft August 30, 2024 10:27
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Sep 3, 2024
@ysolomchenko ysolomchenko changed the title [Instrumentation.Owin] Update documentation [Instrumentation.Owin] Update to Use New Tagging Schema Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.97%. Comparing base (71655ce) to head (94e423d).
Report is 430 commits behind head on main.

Files with missing lines Patch % Lines
...ation.Owin/Implementation/DiagnosticsMiddleware.cs 91.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2028       +/-   ##
===========================================
+ Coverage   73.91%   85.97%   +12.05%     
===========================================
  Files         267        8      -259     
  Lines        9615      164     -9451     
===========================================
- Hits         7107      141     -6966     
+ Misses       2508       23     -2485     
Flag Coverage Δ
unittests-Instrumentation.Owin 85.97% <91.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation.Owin/Implementation/DiagnosticsMiddleware.cs 91.00% <91.66%> (-0.87%) ⬇️

... and 268 files with indirect coverage changes

@ysolomchenko ysolomchenko marked this pull request as ready for review September 4, 2024 09:26
@ysolomchenko ysolomchenko requested a review from Kielek September 4, 2024 09:26
@Kielek Kielek self-requested a review September 6, 2024 11:02
@Kielek Kielek changed the title [Instrumentation.Owin] Update to Use New Tagging Schema [Instrumentation.Owin] Update to semantic convention v1.27.0 Sep 16, 2024
@Kielek
Copy link
Contributor

Kielek commented Sep 16, 2024

@CodeBlanch, merging.
I do not see anything problematic here. If you find something like this post-merge, please let me know.

@Kielek Kielek merged commit d5a630f into open-telemetry:main Sep 16, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.owin Things related to OpenTelemetry.Instrumentation.Owin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation for OTEL_DOTNET_EXPERIMENTAL_OWIN_DISABLE_URL_QUERY_REDACTION
3 participants