-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws] default to use Semantic Convention 1.28 and remove option Legacy #2437
Merged
alanwest
merged 4 commits into
open-telemetry:main
from
ppittle:default-to-1.28-sem-conv
Jan 6, 2025
Merged
[aws] default to use Semantic Convention 1.28 and remove option Legacy #2437
alanwest
merged 4 commits into
open-telemetry:main
from
ppittle:default-to-1.28-sem-conv
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
muhammad-othman,
Oberon00,
rypdal and
srprash
December 20, 2024 01:00
github-actions
bot
added
comp:instrumentation.aws
Things related to OpenTelemetry.Instrumentation.AWS
comp:instrumentation.awslambda
Things related to OpenTelemetry.Instrumentation.AWSLambda
comp:resources.aws
Things related to OpenTelemetry.Resources.AWS
labels
Dec 20, 2024
alanwest
approved these changes
Dec 20, 2024
rajkumar-rangaraj
approved these changes
Dec 20, 2024
muhammad-othman
approved these changes
Dec 22, 2024
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Oberon00
reviewed
Dec 30, 2024
Oberon00
reviewed
Dec 30, 2024
…longer be used directly
ppittle
force-pushed
the
default-to-1.28-sem-conv
branch
from
January 3, 2025 18:58
1c5cffd
to
311410a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
- Coverage 73.91% 0 -73.92%
==========================================
Files 267 0 -267
Lines 9615 0 -9615
==========================================
- Hits 7107 0 -7107
+ Misses 2508 0 -2508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:instrumentation.aws
Things related to OpenTelemetry.Instrumentation.AWS
comp:instrumentation.awslambda
Things related to OpenTelemetry.Instrumentation.AWSLambda
comp:resources.aws
Things related to OpenTelemetry.Resources.AWS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue # Continuation of #2367
Changes
Update the OpenTelemetry.*.AWS libraries to to use Semantic Convention 1.28 and remove the option
SemanticConventionVerisons.Legacy
Background
We determined that #2367, should not change Semantic Conventions by default, allowing users a non-breaking way to test opting in-to 1.28.
This is a fast follow up PR that removes
SemanticConventionVersions.Legacy
and changes the default to SemanticConventionVersions.V1_28_0. This PR is to be released as a Release Candidate.This follows the release strategy for other contrib packages that have made similar breaking changes around Semantic Convention stabilization.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes