Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Exception error from AWS Resource Detectors #2451

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

AsakerMohd
Copy link
Contributor

Changes

Fixed Exception error from AWS Resource Detectors. We realized that while using the resource detectors, instead of throwing the proper error causing the detectors to fail, they were throwing Unsupported type Exception in event source which was hiding the original message. The error was due to one of the events in the EventSource using exception rather that one of the primitive types allowed by the event source. After this change, we are now able to see proper error messages like

[2025-01-03T01:08:16.6219016Z] [Warning] EventSource=OpenTelemetry-Resources-AWS, Message=Certificate file does not exist. File: '/var/run/secrets/kubernetes.io/serviceaccount/ca.crt' 

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@AsakerMohd AsakerMohd requested a review from a team as a code owner January 3, 2025 01:27
@github-actions github-actions bot requested review from ppittle and srprash January 3, 2025 01:27
@github-actions github-actions bot added the comp:resources.aws Things related to OpenTelemetry.Resources.AWS label Jan 3, 2025
@Kielek Kielek merged commit c4a56e0 into open-telemetry:main Jan 3, 2025
61 checks passed
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (71655ce) to head (2a9ca64).
Report is 673 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2451       +/-   ##
===========================================
+ Coverage   73.91%   85.22%   +11.31%     
===========================================
  Files         267       34      -233     
  Lines        9615      819     -8796     
===========================================
- Hits         7107      698     -6409     
+ Misses       2508      121     -2387     

see 274 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants