Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-logs] LogRecordSeverity enum tweaks #4451

Merged
merged 5 commits into from
Apr 28, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 27, 2023

Relates to #4433

Changes

  • Incorporates some early feedback from @alanwest into the enum LogRecordSeverity definition.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated

@CodeBlanch CodeBlanch requested a review from a team April 27, 2023 21:30
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #4451 (3b7c4bb) into main (1b9290e) will decrease coverage by 0.27%.
The diff coverage is 0.00%.

❗ Current head 3b7c4bb differs from pull request most recent head e860c58. Consider uploading reports for the commit e860c58 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4451      +/-   ##
==========================================
- Coverage   84.09%   83.82%   -0.27%     
==========================================
  Files         311      312       +1     
  Lines       12329    12367      +38     
==========================================
- Hits        10368    10367       -1     
- Misses       1961     2000      +39     
Impacted Files Coverage Δ
...nTelemetry.Api/Logs/LogRecordSeverityExtensions.cs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 361750c into open-telemetry:main Apr 28, 2023
@CodeBlanch CodeBlanch deleted the api-logs-severitynumber branch April 28, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants