-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zpages #4604
Remove zpages #4604
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4604 +/- ##
==========================================
- Coverage 85.25% 85.20% -0.06%
==========================================
Files 320 312 -8
Lines 12753 12532 -221
==========================================
- Hits 10873 10678 -195
+ Misses 1880 1854 -26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AutoInstrumentation is not using this package.
Please remember to deprecate it also on nuget.org side (worth to make a bit bigger cleanup open-telemetry/opentelemetry-dotnet-contrib#1100).
https://github.com/open-telemetry/opentelemetry-specification/blob/main/experimental/trace/zpages.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with this.
Maintainers may either keep a readme.md page with this info or update the nuget package to indicate its deprecaed.
Remove the ZPages component: