Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zpages #4604

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Remove zpages #4604

merged 3 commits into from
Jun 21, 2023

Conversation

reyang
Copy link
Member

@reyang reyang commented Jun 19, 2023

Remove the ZPages component:

@reyang reyang requested a review from a team June 19, 2023 02:54
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #4604 (c13bf29) into main (4712c3a) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4604      +/-   ##
==========================================
- Coverage   85.25%   85.20%   -0.06%     
==========================================
  Files         320      312       -8     
  Lines       12753    12532     -221     
==========================================
- Hits        10873    10678     -195     
+ Misses       1880     1854      -26     

see 5 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoInstrumentation is not using this package.

Please remember to deprecate it also on nuget.org side (worth to make a bit bigger cleanup open-telemetry/opentelemetry-dotnet-contrib#1100).

@cijothomas
Copy link
Member

There is no plan to make this official from the specification perspective.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/experimental/trace/zpages.md
Would this doc be updated to indicate so?

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this.
Maintainers may either keep a readme.md page with this info or update the nuget package to indicate its deprecaed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants