Add WithResource option for the remote sampler constructor #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add tests? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3658 +/- ##
=======================================
- Coverage 69.9% 69.8% -0.2%
=======================================
Files 147 147
Lines 6960 6977 +17
=======================================
+ Hits 4871 4875 +4
- Misses 1963 1977 +14
+ Partials 126 125 -1
|
|
Closed as I will create a new PR that may be potentially different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent across the OTel SDK XRay samplers, the service name and cloud platform fields of the Remote Sampler should be able to be retrieved from a Resource. Currently, These fields are only configurable through the Remote Sampler constructor.
Context of Issue:
The resource of the TracerProvider is not available to the sampler (GH Issue), and it does not look like it will be anytime soon. As an alternative, the resource should be able to be passed into the sampler instantiation.