Move opencensus binary propagation to contrib #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
dashpole
changed the title
dashpole
force-pushed
the
opencensus_binary_move
branch
2 times, most recently
from
88132c1 to
14d656e
Compare
MrAlias
reviewed
Nov 24, 2020
dashpole
force-pushed
the
opencensus_binary_move
branch
from
14d656e to
af17b40
Compare
dashpole
force-pushed
the
opencensus_binary_move
branch
from
af17b40 to
7e127f2
Compare
MrAlias
approved these changes
Nov 24, 2020
Aneurysm9
approved these changes
Nov 27, 2020
XSAM
approved these changes
Nov 28, 2020
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Remove binary propagators They are in process of being dropped from the specification and we haven't be using them anywhere in the project. Can reintroduce them later. * Rename Supplier to HTTPSupplier The supplier is used only in HTTP propagators currently. It's not clear if it will be useful for binary propagators if they get to be specified at some point. * Rework propagation interfaces The biggest change here is that HTTP extractors return a new context with whatever information the propagator is able to retrieve from the supplier. Such interface does not hardcode any extractor's functionality (like it was before by explicitly returning a span context and correlation context) and makes it easy to chain multiple propagators. Injection part hasn't changed. * Add Propagators interface This interface (and its default implementation) is likely going to be the propagation API used the most. Single injectors, extractors or propagators are likely going to be used just as parameters to the Option functions that configure the Propagators implementation. * Drop noop propagator It's rather pointless - just create an empty Propagators instance. * Fix wrong name in docs Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: open-telemetry/opentelemetry-go#93
This was originally added to opentelemetry-go in open-telemetry/opentelemetry-go#1334, but we decided it should be moved to contrib.
This copies the binary propagation, and adds a new go module so that opencensus dependencies aren't added to users of other propagation formats.