Protect against multiple WriteHeader calls #6113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the RespWriterWrapper there was a logic issue. The instance tracks whether WriteHeader has been called or not, but was still attempting to call it again even when it had already been called. This updates the internal implementation to recognize if it's already been called and make any additional attempts a no-op. This avoids errors bubbling up for "superfluous response.WriteHeader calls". Signed-off-by: Sean McGinnis <[email protected]>
|
This is not the right fix, as you can see from the unit tests. Are you using the latest release? 2 superfluous header issues were fixed in that latest release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the RespWriterWrapper there was a logic issue. The instance tracks whether WriteHeader has been called or not, but was still attempting to call it again even when it had already been called.
This updates the internal implementation to recognize if it's already been called and make any additional attempts a no-op. This avoids errors bubbling up for "superfluous response.WriteHeader calls".
Closes: #6112