Call NewSpanExporter without checking OTLP_TRACES_EXPORTER environment variable #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Jan 9, 2025
|
Please be sure to include a changelog entry describing the fix being applied. |
ManiaKazemzadeh
force-pushed
the
fix-span-exporter-behaviour
branch
from
f1cee98 to
0d43862
Compare
|
Hey, thank you for the review! I've added your suggestions. I spent some time trying to understand and see if there was another way of testing the exporter type but your suggestion to use MarshalLog seems to be the best solution. I've also added a changelog item. Please let me know if there are any other changes you'd like me to make 👍 |
MrAlias
approved these changes
Jan 10, 2025
ManiaKazemzadeh
force-pushed
the
fix-span-exporter-behaviour
branch
from
0d43862 to
bc10fad
Compare
RonFed
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
OTEL_TRACES_EXPORTERis not defined, then the trace exporter is always set to HTTP, regardless of the value ofOTEL_EXPORTER_OTLP_PROTOCOL. This is because there is a check to see ifOTEL_TRACES_EXPORTERis set before callingautoexport.NewSpanExporter.This change removes that check and adds a test to ensure that
autoexport.NewSpanExporterstill works withoutOTEL_TRACES_EXPORTERdefined. I have left the fallback code in place here so that ifOTEL_EXPORTER_OTLP_PROTOCOLhas an invalid value (or NewSpanExporter returns nil for any other reason) the http exporter will be selected (which is the current behaviour).